View textile source
Review Request #103 - Created Dec. 9, 2009 and updated
Information | |
---|---|
Savin Tiberiu | |
infoarena | |
Reviewers | |
hackers | |
Adds a "Vezi sursa" button on the page header and in the history table. Also there is a "Vezi pagina" button that takes you back from the source to the page.
-
/trunk/www/controllers/textblock.php (Diff revision 1) -
Unrelated to this review, but this line can be deleted :)
-
/trunk/www/controllers/textblock.php (Diff revision 1) -
Should there also be a separation between history-view and history-view-source if we have "view" and "view-source"? Diff between pages, for example, should use history-view-source.
-
/trunk/www/controllers/textblock.php (Diff revision 1) -
This should be textblock-view-source if (!$wiki_process)
-
/trunk/www/views/textblock_view.php (Diff revision 1) -
Add a CSS class, instead of inline styles. It looks very bad on my laptop which is 1024x768 (150 columns don't fit). I think you should remove cols=150 and add width: 99% in CSS and leave it scrollable. Adding a fixed-width font would probably be good also. Also it looks fine when viewing source for a specified revision, but when viewing without revision it appears below the navigation bar on the left (on chromium)