Large files could be uploaded by zipping them
Review Request #104 - Created Dec. 10, 2009 and submitted
| Information | |
|---|---|
| Savin Tiberiu | |
| infoarena | |
| Reviewers | |
| hackers | |
Large files could be uploaded by zipping them. This patch should solve the problem. Also made some changes so that the messages are gramatically correct.
Did you check for other appearances of get_zipped_attachments in the code to make sure it works?
-
/trunk/www/controllers/attachment.php (Diff revision 1) -
empty line
-
/trunk/www/controllers/attachment.php (Diff revision 1) -
space at end of line
-
/trunk/www/controllers/attachment.php (Diff revision 1) -
space at end of line
-
/trunk/www/controllers/attachment.php (Diff revision 1) -
"era mai mare decat limita permisa sau era invalid" is more user-friendly:)
-
/trunk/www/controllers/zip_attachment.php (Diff revision 1) -
How do we treat directories? We shouldn't count them as skipped "files" I think, we should just ignore them
-
/trunk/www/controllers/zip_attachment.php (Diff revision 1) -
space at end of line
Review request changed
Change Summary:
I don't know what's with those trailing spaces. They don't appear in my vim.
Diff: |
Revision 2 (+29 -6) |
|---|