Live eval
Review Request #12 - Created Oct. 19, 2008 and submitted
Information | |
---|---|
Bogdan-Cristian Tătăroiu | |
infoarena | |
Reviewers | |
hackers | |
revision 911, part of 912
this has been tested with two contests at ichb.
-
/trunk/common/db/job.php (Diff revision 1) -
What happens with all the "null" round id jobs?
-
/trunk/common/db/job.php (Diff revision 1) -
What happens with all the "null" round id jobs?
-
/trunk/common/db/job.php (Diff revision 1) -
We need more comments in out code :) I don't get it, why do you join with round when you have score_begin and score_end?
-
/trunk/common/round.php (Diff revision 1) -
Why not use booleans?
-
/trunk/common/round.php (Diff revision 1) -
One the round is stopped the results are public, right? I know it's a corner case but in final contest rounds we hide the results even after the round is finished and publish them later, on a projector. Is there some way we can still do that?
-
/trunk/common/security.php (Diff revision 1) -
;; at end of line
-
/trunk/scripts/live-eval (Diff revision 1) -
Am I missing something? If you change "allow_eval" to "public_eval" past rounds which have allow_eval = 0 will now have public_eval = 0, so you won't be able to see the results anymore.
Review request changed