Added task ratings functionality and changed the task edit related pages UI.
Review Request #140 - Created March 18, 2010 and submitted
| Information | |
|---|---|
| Andrei Grigorean | |
| infoarena | |
| Reviewers | |
| hackers | |
- Replaced all the edit links in a task page with a single 'Editeaza' link. - All the task related edit pages are grouped together using tabs. - Created a task ratings page. This change includes the stuff from http://reviewboard.infoarena.ro/r/137/diff/
Great stuff, only minor comments. Please commit this change before starting to work on querying for untagged tasks.
-
trunk/common/db/task_rating.php (Diff revision 1) -
Rename to task_rating_get_all
-
trunk/common/db/task_rating.php (Diff revision 1) -
Rename to task_rating_get
-
trunk/common/db/task_rating.php (Diff revision 1) -
Evil trailing spaces.
-
trunk/common/task_rating.php (Diff revision 1) -
There is no need to put this in here also. Just define it in common/db
-
trunk/common/task_rating.php (Diff revision 1) -
We have a is_whole_number function that returns true for strings that are integers also. Maybe use that?
-
trunk/www/controllers/task.php (Diff revision 1) -
Evil trailing spaces
-
trunk/www/url.php (Diff revision 1) -
array('action -
trunk/www/views/task_edit_header.php (Diff revision 1) -
Theoretically, you should do a check for each permission: task-edit, task-edit, task-tag and task-edit-ratings. :)
-
trunk/www/views/task_rating_edit.php (Diff revision 1) -
Evil trailing space
-
trunk/www/views/task_tag_edit.php (Diff revision 1) -
Salvează
-
trunk/www/views/textblock_edit.php (Diff revision 1) -
Evil trailing space.
-
trunk/www/views/textblock_edit.php (Diff revision 1) -
Add an <h1>Editare enunţ ...</h1>
-
trunk/www/views/textblock_header.php (Diff revision 1) -
Evil trailing space :P
Review request changed