Task reordering takes care of forum topics
Review Request #153 - Created April 23, 2010 and submitted
| Information | |
|---|---|
| Andrei Grigorean | |
| infoarena | |
| Reviewers | |
| hackers | |
When the order_id for a task in the archive changes, the corresponding forum topic gets updated (including all the replies, which is very time consuming). Also modified a script to take care of the topics.
-
branches/taskreordering/common/db/task.php (Diff revision 2) -
Theoretically, a task can have a different page then problema/id. Sadly, there is a task property called page_name which points to the task's textblock and which MAY be different (though i'm not sure it ever is).
-
branches/taskreordering/common/db/task.php (Diff revision 2) -
This would be a good opportunity to incorporate scripts/link-task-forum into our codebase, although it's not necessary. :)
-
branches/taskreordering/common/db/task.php (Diff revision 2) -
We have a problem with tasks that have been added through the Implica-te project. We like to praise our users that contribute to our site. :)
Review request changed
Change Summary:
Fixed bugs: Textblock is read from the db and community praising is safe.
Diff: |
Revision 3 (+117 -14) |
|---|
-
branches/taskreordering/common/db/task.php (Diff revisions 2 - 3) -
Are you sure this works? UTF-8 characters have variable length (from 1 to 4 bytes I think) and substr is oblivious to that fact. I think you should use mb_substr.
-
branches/taskreordering/common/db/task.php (Diff revisions 2 - 3) -
You should add diacritics here :) ţ not ț
Hackish, but if it works, ok :P