View textile source
Review Request #165 - Created June 1, 2010 and updated
Information | |
---|---|
Teodor Pripoae | |
infoarena | |
Reviewers | |
hackers | |
ticket 387
I think there is a file missing from the diff (views/textblock_view_source.php). Also there is already a diff for this change, I wrote a while ago. You can check it out http://reviewboard.infoarena.ro/r/103/
-
trunk/www/controllers/textblock.php (Diff revision 1) -
Ev space
-
trunk/www/controllers/textblock.php (Diff revision 1) -
What is this for?
-
trunk/www/controllers/textblock.php (Diff revision 1) -
weird ident
-
trunk/www/controllers/textblock.php (Diff revision 1) -
Ev space
-
trunk/www/controllers/textblock.php (Diff revision 1) -
Is this file present on our repository or did you forgot to put in the diff?
A few extra comments.
-
trunk/www/controllers/textblock.php (Diff revision 1) -
Not checking for permissions is pretty bad. :) Simple users should not be able to see hidden tasks.
-
trunk/www/controllers/textblock.php (Diff revision 1) -
You're mixing tabs and spaces from what I can see.