Two bugfixes

Reviews
Diff

- Download Diff

Information
Submitter:	Savin Tiberiu
Repository:	infoarena
Branch:
Bugs:
Depends On:
Reviewers
Groups:	hackers
People:

Description

Fixed two small bugs.

1. Hopefully now interns will be able to see scores for the tasks they own.

2. Job reeval wouldn't work (a crash would appear) if there was no task filter involved.

Testing Done

Ship it!

While you're at it, I remember job_reeval crashing on some filters as well, such as job_id. Could you check to see inconsistencies between parameters for monitor and for reeval and fix if it's easy to do so?

Savin Tiberiu Oct. 19, 2011, 6:18 p.m.

job_id filter wouldn't work because there was no task filter. That was actually the bug I was trying to fix.

Bogdan-Cristian Tătăroiu Oct. 19, 2011, 6:53 p.m.

Oops... It was 7:20 am, I didn't read it properly. :) ship ship

/trunk/www/controllers/reeval.php (Diff revision 1)

Y u log_print_r in production?

Savin Tiberiu Oct. 19, 2011, 6:18 p.m.
```
Cause I can. Wait... can I?
```

Bogdan-Cristian Tătăroiu Oct. 19, 2011, 6:53 p.m.

You can, but it adds to our logs. If you want to have it for debugging for a while, I would say add a nice string line before it saying "Reevaling jobs with filters:" so we can grep for it.

You have a pending review.

Review Board 2.5.13.1

Screenshots

Files

Status: Closed (submitted)