Fixxing the errors that appeared during the deployment of the avatar optimization
Review Request #181 - Created Nov. 13, 2011 and submitted
| Information | |
|---|---|
| Adrian Budau | |
| infoarena | |
| Reviewers | |
| hackers | |
Corrected the image_resize script. It used to make an infinite loop somehow on GIF's which have no transparent color. Removed the creation of the folders from the setup because i couldnt know exactly the location of the placeholder image so that the script wouldn't need to be run at all. It would be easier if the folders would be sent with the commit because they would not affect the real site(the folders already exist). So a fresh install would not need to run this script. Did some minor changing to the code(some lines were longer than 80 characters). An user cannot change his avatar through the attachment page(an error will tell him to change it from his profile page) but he can delete it from there and from his account page too(there is a shortcut). An avatar can only be jpeg, png or gif so i added a different array with these mime_types. The others are yet to be permitted.
Issues
- 2
- 1
- 0
- 3
| Description | From | Last Updated |
|---|---|---|
| What does $matches[2] == '' do? |
Bogdan-Cristian Tătăroiu
|
|
| Does removing this fix it? I know it's broken right now, but it does work on Firefox afaik, no need ... |
Bogdan-Cristian Tătăroiu
|
Good job. Please update your diff against the last svn revision, since I committed half of these changes already from live :)
-
trunk/common/attachment.php (Diff revision 1) -
if (...) { } -
trunk/common/avatar.php (Diff revision 1) -
return mixed Error message or null on success
-
trunk/common/avatar.php (Diff revision 1) -
I wanted to ask what the 'a' was for.
-
trunk/scripts/setup (Diff revision 1) -
Run the make-avatar-folder from the setup script. New developers should be able to run ./setup and have everything set up for them.
-
trunk/www/controllers/attachment.php (Diff revision 1) -
Improper alignment i think
-
trunk/www/controllers/attachment.php (Diff revision 1) -
What does $matches[2] == '' do?
-
trunk/www/controllers/attachment.php (Diff revision 1) -
if (...) { } -
trunk/www/views/account.php (Diff revision 1) -
Cool :D
Good stuff
-
trunk/www/index.php (Diff revision 2) -
attach-bulk-action maybe? To make it consistent with all other attach- actions.
-
trunk/www/views/listattach.php (Diff revision 2) -
Does removing this fix it? I know it's broken right now, but it does work on Firefox afaik, no need to break it on that as well