Linting engine using Facebook's Arcanist.
Review Request #200 - Created March 4, 2012 and submitted
| Information | |
|---|---|
| Bogdan-Cristian Tătăroiu | |
| infoarena | |
| Reviewers | |
| hackers | |
Arcanist is mainly a command line tool for code review and revision management. We will only use it for linting our source code _for now_. The linter is pure awesome and it will check everything from naming conventions, line width, uninitialized variables to file names and spelling. Typing 'make lint' will download a copy of arcanist and libphutil from github on the first run. It will then run the linter on any files that you have touched during your commit, while mostly only looking on the lines you've changed. 'make lint-all' will be a bit more thorough and look at the entire files. 'make lint-repo' will run the linter on the entire codebase, which will make you quietly weep. From this point, either 'make lint' or 'make lint-all' (preferred) will have to be run before any change posted for review.
Issues
- 2
- 0
- 0
- 2
| Description | From | Last Updated |
|---|---|---|
| We're you trying to add something more with "The" ? |
Adrian Budau
|
|
| Aren't we testing only source files? Romanian characters shouldn't be in them (still they are in mysql operations on textblocks). ... |
Adrian Budau
|
Still haven't tested on my clone(can't boot into linux right now). The code looks flawless overall.
-
trunk/lint/engine/InfoarenaLintEngine.php (Diff revision 1) -
We're you trying to add something more with "The" ?
-
trunk/lint/engine/InfoarenaLintEngine.php (Diff revision 1) -
Aren't we testing only source files? Romanian characters shouldn't be in them (still they are in mysql operations on textblocks). My opinion on this is that this should be a problem we should fix not one we overlook.
Are you sure this is stable? Last I knew the open-source version of arcanist was not at all stable. It would be great if we had this and it if was stable, but I think we should do some comprehensive tests on it.
Review request changed
Change Summary:
Disabled 80 character limit for views, removed forgotten print and completed comments.
Diff: |
Revision 2 (+269 -1) |
|---|
Tested all commands. They work as expected(actually better "Possible spelling error. You wrote 'usefull', but did you mean 'useful'") It would be better if the Makefile would create 3 scripts instead or running them. This way you could deliver the lint-repo message through "less" (lint-repo | less). It's quite buggy right now if you try "make lint-repo | less"