Further cleanups to eval code in preparation for interactive tasks.

Reviews
Diff

- Download Diff

Information
Submitter:	Bogdan-Cristian Tătăroiu
Repository:	infoarena
Branch:
Bugs:
Depends On:
Reviewers
Groups:	hackers
People:

Description

- Fixed error handling for various methods such as chmod, which would
  have raised PHP warnings and killed the eval.
- Replace previous hack with exceptions whenever judging a job needed
  to be interrupted due to an error. Replaced all log_error and
  log_assert with calls to eval_assert, which raises a EvalSystemError
  on failed assertion.
- Got rid of task parameters in the grader code. Parameters are now
  merged into the $task object.
- Linting fixes.
- Fix site crash when mbstring extension not present.

Testing Done

Issues

0
2
0
All Issues: 2

Description	From	Last Updated
Make it abstract?	Adrian Budau	June 24, 2012, 1:39 a.m.
Same here	Adrian Budau	June 24, 2012, 1:39 a.m.

Ship it!

Great job. I hope you tested all possible exception cases.

trunk/eval/BaseGrader.php (Diff revision 1)

Are you sure there are no more problems with preg_match? In php 5.3 ubuntu 11.10 I know I had some problems with it(not here but still with preg_match).

Bogdan-Cristian Tătăroiu June 24, 2012, 2:11 a.m.

Ok, I've replaced it with strtok, since it really can't go wrong and it makes more sense. :)

trunk/eval/Exceptions.php (Diff revision 1)

Show all issues

Make it abstract?

Bogdan-Cristian Tătăroiu June 24, 2012, 2:11 a.m.

For some reason, I thought I couldn't do try { } catch (EvalException $e) {} if it was abstract. It seems to work though. :)

trunk/eval/Exceptions.php (Diff revision 1)

Show all issues

Same here

Change Summary:

Addressed comments.

Diff:

Revision 2 (+165 -196)

Show changes

	trunk/common/common.php
	trunk/eval/BaseGrader.php
	trunk/eval/ClassicGrader.php
	trunk/eval/Exceptions.php
	trunk/eval/download.php
	trunk/eval/eval
	trunk/eval/utilities.php
	trunk/jrun/Makefile

You have a pending review.

Review Board 2.5.13.1

Screenshots

Files

Issues

Change Summary:

Diff:

Status: Closed (submitted)