I have added a column with radio buttons in textblock_history view to compare specific revisions.
Review Request #26 - Created Nov. 15, 2008 and submitted
Information | |
---|---|
Victor Rusu | |
infoarena | |
Reviewers | |
hackers | |
ticket 59
-
trunk/www/views/textblock_history.php (Diff revision 2) -
Read http://hackers.devnet.ro/wiki/CodingStandards. The format is "function name(args) {"
-
trunk/www/views/textblock_history.php (Diff revision 2) -
Don't hardcode HTML in here. Check out the functions in www/format/form.php. You can probably use one of them (suspect: format_form_field_inner_editor) or you can create your own in there.
-
trunk/www/views/textblock_history.php (Diff revision 2) -
Maybe use "button important".
-
trunk/www/views/textblock_history.php (Diff revision 2) -
Let's use "get" here.
-
trunk/www/views/textblock_history.php (Diff revision 2) -
Let's use "get" here.
Ignore comments from diff 4, reviewboard is stupid and won't delete them :) Code is good, just make those 2 changes I said and ship it.
-
trunk/www/format/form.php (Diff revision 4) -
Evil space.
-
trunk/www/format/form.php (Diff revision 4) -
Evil space.
-
trunk/www/views/textblock_history.php (Diff revision 6) -
Try to make all lines fit into 80 columns (part of coding standards) return format_radio_button(...) . " " . format_radio_button(...)
-
trunk/www/views/textblock_history.php (Diff revision 6) -
Add a comment here telling why this was necessary, since it's not immediately clear.