I added the copy functionality for wiki pages
Review Request #27 - Created Nov. 15, 2008 and submitted
| Information | |
|---|---|
| Andrei Grigorean | |
| infoarena | |
| Reviewers | |
| hackers | |
Most of the code was copy pasted from the move functionality
-
trunk/common/db/textblock.php (Diff revision 1) -
Don't leave commented code here unless it makes sense.
-
trunk/common/db/textblock.php (Diff revision 1) -
Trailing space.
-
trunk/common/db/textblock.php (Diff revision 1) -
More comments here. What are you doing?
-
trunk/common/db/textblock.php (Diff revision 1) -
Evil spaces :)
-
trunk/common/db/textblock.php (Diff revision 1) -
What does this block do?
-
trunk/www/views/textblock_header.php (Diff revision 1) -
Change the shortcut key.
-
trunk/www/views/textblock_move.php (Diff revision 1) -
Random blank lines.
-
trunk/www/views/textblock_move.php (Diff revision 1) -
Blank line.
Mostly small changes :)
-
trunk/common/db/textblock.php (Diff revision 2) -
Change $old_task to $old_textblock.
-
trunk/common/db/textblock.php (Diff revision 2) -
$identity_user['id'] should be replaced with identity_get_user_id()
-
trunk/www/views/textblock_copy.php (Diff revision 2) -
Class should be "copy clear" instead of "move clear".
-
trunk/common/db/textblock.php (Diff revision 3) -
Why not use textblock_add_revision? Shouldn't you also set the timestamps and the user id?