Moved news to blog and added snippet support (ticket #348)
Review Request #28 - Created Nov. 15, 2008 and submitted
| Information | |
|---|---|
| Silviu Ganceanu | |
| infoarena | |
| Reviewers | |
| hackers | |
- Added an external lib (simplehtmldom) which creates a dom tree out of a html page. - Implemented a snippet blog preview. - Script to move news to blog and tag them. - Modified htaccess.sample to redirect from stiri/* to blog/* - Removed news_rss.
-
/trunk/www/htaccess.sample (Diff revision 2) -
Don't hardcode your path.
-
/trunk/www/views/blog_view.php (Diff revision 2) -
Cristi suggested another solution by trimming the Textile code, before it becomes HTML. I think that could be a better approach.
Review request changed
Change Summary:
- fixed one comment from Mircea - added cache support for snippets
Diff: |
Revision 3 (+1034 -46) |
|---|
-
trunk/common/textblock.php (Diff revision 3) -
Maybe handle NULL urls.
-
trunk/www/controllers/blog.php (Diff revision 3) -
around, should
-
trunk/www/macros/macro_blogpreview.php (Diff revision 3) -
I think it may be better if this was moved in common/textblock.php since this function could be used from other parts of the site in the future. If we do that, the check for "stiri" tag should be moved in the macro function
-
trunk/www/macros/macro_blogpreview.php (Diff revision 3) -
html_escape($url)
-
trunk/www/views/blog_view.php (Diff revision 3) -
Why do we keep a link to the current page in the title?
Review request changed
Review request changed
Change Summary:
- fixed cache related bug: $whole_news is now part of the $cache_id
Diff: |
Revision 5 (+1043 -46) |
|---|
Review request changed
Only minor comments, looks good to me in general!
-
trunk/common/external-libs/simple_html_dom.php (Diff revision 3) -
Maybe use - instead of _, we don't use - anywhere else in folder names.
-
trunk/common/textblock.php (Diff revision 6) -
You can send a parameter to get_snippet to remove the images or not.
-
trunk/www/views/blog_view.php (Diff revision 6) -
There's no need to hijack the title here, just put a h1.
Review request changed
Change Summary:
- another round of fixed comments (from Mircea & Bogdan)
Diff: |
Revision 7 (+1046 -46) |
|---|