HTML Newsletter and migration script

Reviews
Diff

- Download Diff

Information
Submitter:	Cristian George Strat
Repository:	infoarena
Branch:
Bugs:
Depends On:
Reviewers
Groups:	hackers
People:

Description

HTML Newsletter

This patch adds support for HTML in the infoarena newsletter. A newsletter can be created just like a regular wiki page, using textile, macros, and templates. Sending is still done with a command-line script.

- Adds HTML newsletter library.
- Adds UI, display index of all newsletters.
- Adds UI, view newsletter in browser.
- Adds migration script to convert old text/plain newsletters to decent textile versions.
- Adds external library: PHPMailer (http://phpmailer.codeworxtech.com/index.php?pg=phpmailer).

Testing Done

/trunk/www/macros/macro_newsletterrating.php (Diff revision 1)

Why is this file twice?

Ship it!

This looks so cool :)

/trunk/www/controllers/textblock.php (Diff revision 1)

Unrelated to this changeset: I think the blog view controller can be merged with this now.

/trunk/www/index.php (Diff revision 1)

This needs to be defined in config.php.sample

Cristian George Strat Jan. 19, 2009, 7:44 a.m.
```
Done
```

/trunk/www/macros/macro_newsletterrating.php (Diff revision 1)

Shouldn't there be a return '' when false? (is it ever false?)

Cristian George Strat Jan. 19, 2009, 7:45 a.m.

Done. I think it is false, at least when rating_cache is NULL.

/trunk/www/static/js/newsletter.js (Diff revision 1)

This doesn't really work for me on firefox 3. Neither resizing the frame nor hijacking the links (i assume this is for viewing in the browser right?)

Cristian George Strat Jan. 19, 2009, 8:29 a.m.

This is odd.

I tested it with FF3, IE6, and Opera 9. I'll look into it later.

Bogdan-Cristian Tătăroiu Jan. 19, 2009, 3:29 p.m.

Sorry about that, it works, the js script wasn't readable when I tested it.

A few more comments

/trunk/common/class.smtp.php (Diff revision 1)

Another duplicate file, delete this :)

Cristian George Strat Jan. 19, 2009, 7:46 a.m.
```
Done
```

/trunk/common/newsletter_template.php (Diff revision 1)

Don't border="0" and style="border:0" mean the same thing? (border isn't valid in xhtml)

Cristian George Strat Jan. 19, 2009, 7:53 a.m.

`border` is valid HTML4. The email message has no explicit DOCTYPE, the email client would probably ignore it anyway.

Yes, they mean the same thing, but I'm hoping at least one would work if the other is stripped by the email client. For the same reason, many other style rules are duplicated throughout the document.

/trunk/common/newsletter_template.php (Diff revision 1)

xhtml validation complains inline elements like <span> can't contain block elements like <p>. <div> should look the same way

Cristian George Strat Jan. 19, 2009, 8:26 a.m.
```
Done
```

Change Summary:

Thanks for the comments. Here is the updated diff. I'll put it on production now.

Diff:

Revision 2 (+3673 -122)

Show changes

	/trunk/config.php.sample
	/trunk/common/newsletter.php
	/trunk/common/newsletter_template.php
	/trunk/common/db/textblock.php
	/trunk/common/external_libs/class.phpmailer.php
	/trunk/common/external_libs/class.smtp.php
	/trunk/scripts/migrate-newsletters-to-html
	/trunk/scripts/send-newsletter
	11 more

You have a pending review.

Review Board 2.5.13.1

Screenshots

Files

Change Summary:

Diff: