/trunk/common/db/textblock.php (Diff revision 3)

Use 4 spaces for tab

/trunk/www/controllers/textblock.php (Diff revision 3)

Extra whitespace.

You need to check if request is POST, so a admin can't be tricked into clicking a link infoarena.ro/home?action=delete-revision&revision=blahblah. Look at other controllers to see how.

Also use identity_require to check if user can delete the revision. Something like: identity_require("textblock-delete-revision", $revision)

/trunk/www/controllers/textblock.php (Diff revision 3)

Check if page exists?

/trunk/www/views/textblock_history.php (Diff revision 3)

Extra whitespace.

/trunk/www/views/textblock_history.php (Diff revision 3)

I'm not sure it's a good idea to get every revision since there can be up to 200 revisions on a page. Better just display the link to everybody. The check should be done in the controller anyway.

/trunk/www/views/textblock_history.php (Diff revision 3)

Use format_post_link like with restore.

We're getting close.

/trunk/common/db/textblock.php (Diff revisions 4 - 5)

"LIMIT 1", else you'll query for all revisions.

/trunk/common/db/textblock.php (Diff revisions 4 - 5)

It's easier to do something like

REPLACE INTO `ia_textblock` (
    SELECT * FROM `ia_textblock_revision`
    WHERE `name` = "blahblah"
    ORDER BY `timestamp` DESC" LIMIT 1
);

It works since ia_textblock and ia_textblock_revision have the same columns in the same order :)

/trunk/www/controllers/textblock.php (Diff revisions 4 - 5)

I don't think it's a good idea to pass number of revisions as a parameter, since that number can change from when you displayed the link to someone and when it was clicked. I'm pretty sure there is a function which counts the number of revisions (textblock_get_revision_count I think and counting is fast in the database).

/trunk/www/views/revision_warning.php (Diff revision 5)

Here you can use identity_can since you already have the revision and don't have to get it from the db like with textblock history.