Integrated comments for every page of the wiki similar to the blog (ticket #362)
Review Request #62 - Created Feb. 6, 2009 and submitted
| Information | |
|---|---|
| Stefan Istrate | |
| infoarena | |
| Reviewers | |
| hackers | |
I have integrated for every page of the wiki the current mechanism used for the blog comments. I got rid of the SmfTopic macro used before. I also added pagination and parameter to hide discussions. For the blog posts, the discussion is showed by default. For every other page, it is hidden. The remaining SmfTopic macro may be used in the future for pages where the discussion should be showed by default.
-
trunk/smf/SSI.php (Diff revision 2) -
Don't hardcode 10, pass as parameter
-
trunk/smf/SSI.php (Diff revision 2) -
db_quote($begin_comm)
Forgot to ship it
Review request changed
Change Summary:
I followed Bogdan's advices and I introduced a variable $max_comm instead of '10'. This is the updated diff. I will send it via SVN now.
Diff: |
Revision 3 (+149 -111) |
|---|
Here are some more comments. :)
-
trunk/smf/SSI.php (Diff revision 3) -
I was thinking about putting $max_comm = 10 here, the same way you did with display and begin_comm.
-
trunk/smf/SSI.php (Diff revision 3) -
I think it would be easier for users if the post comment part would be shown even when display is "hide". It's confusing to click on a link to get another link to post :)
-
trunk/www/macros/macro_remotebox.php (Diff revision 3) -
html_escape($args['display']) also.
-
trunk/www/macros/macro_smfcomments.php (Diff revision 3) -
display and number_of_comments should be passed to this macro.
-
trunk/www/views/blog_view.php (Diff revision 3) -
macro_smfcomments should be used here.
-
trunk/www/views/textblock_view.php (Diff revision 3) -
macro_smfcomments should be used here.
Review request changed
Change Summary:
I've done the changes suggested by Bogdan. Waiting for more comments. :)
Diff: |
Revision 4 (+54 -31) |
|---|
Looks good, only small comments.
-
trunk/www/macros/macro_smfcomments.php (Diff revision 4) -
Check if display is "show" or "hide" also.
-
trunk/www/macros/macro_smfcomments.php (Diff revision 4) -
Check if max_comm is number. (There is a is_whole_number function as far as I know).
-
trunk/www/macros/macro_smfcomments.php (Diff revision 4) -
This has to be true, so users can see the comments. (Only admins can right now).
-
trunk/www/views/blog_view.php (Diff revision 4) -
"true" here is extra (not used).
-
trunk/www/views/textblock_view.php (Diff revision 4) -
Same thing about true.