Paginator at the end of wiki page comments
Review Request #67 - Created Feb. 27, 2009 and submitted
| Information | |
|---|---|
| Diana Kelerman | |
| infoarena | |
| Reviewers | |
| hackers | |
Fixes http://hackers.devnet.ro/ticket/368
-
trunk/smf/SSI.php (Diff revision 1) -
There's an useless empty line here.
-
trunk/www/static/js/remotebox.js (Diff revision 1) -
Because of this "connect" function, MochiKit will call RemoteBox_Load once with a different parameter, not "true" or "false". It would have been better to keep this function without parameters, but in this situation I think it's acceptable. :)
Review request changed
Change Summary:
Refactoring: Modiffyed the RemoteBox_Load function to be a general one. Moved everything specific to the comments in RemoteBox_BlogPost. The Load function still has a parameter, namely a final function to be called after the box has been displayed.
Diff: |
Revision 2 (+47 -21) |
|---|
Review request changed
Change Summary:
Refactoring: Modifyed the RemoteBox_Load function to be a general one. Moved everything specific to the comments in RemoteBox_BlogPost. The Load function still has a parameter, namely a final function to be called after the box has been displayed.
Diff: |
Revision 3 (+47 -21) |
|---|
Review request changed
It needs a few more changes and it's done. :)
-
trunk/www/macros/macro_remotebox.php (Diff revision 4) -
Because of this change, you messed up a little bit the other macros that use remotebox. Take a look on macro_smftopic and macro_smftopics and change them to the new parameters.
-
trunk/www/macros/macro_smfcomments.php (Diff revision 4) -
Remove these trailing spaces.
-
trunk/www/static/js/remotebox.js (Diff revision 4) -
The name "RemoteBox_BlogPost" is not suggestive, because comments aren't only for blog.
Review request changed