trunk/common/job.php (Diff revision 1)

Use "concurs" instead of "runda".

trunk/common/job.php (Diff revision 1)

"concurs" here also.

trunk/common/job.php (Diff revision 1)

What happens to old jobs that don't have a round?

trunk/www/controllers/json.php (Diff revision 1)

Add a FIXME here, we need to refactor this.

trunk/www/controllers/submit.php (Diff revision 1)

Use request() in all of them.

Hi! This is a good patch and an important step towards decent rankings and stats.

trunk/common/db/task.php (Diff revision 2)

Extend comment with "running round ids that include this task and $user_id is allowed to submit", otherwise it's just a filtered task_get_parent_rounds()

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 5:38 a.m.

   done

trunk/common/db/task.php (Diff revision 2)

You shouldn't use identity_can() in common/*. Consider passing a user_id instead.

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 5:38 a.m.

   done

trunk/common/job.php (Diff revision 2)

Trailing whitespace.

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 5:38 a.m.

   fixed

trunk/common/task.php (Diff revision 2)

I think this function should go inside www/ as it depends on $_SESSION and identity_can() and thus requires a www environment.

Moreover, it contains UI bits such as "title" => "[ Alegeti runda ]" which are hardly "business logic." :)

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 6:50 a.m.

   I don't really know where to put it so it is accessible from both the submit controller and the macro. It doesn't really go into www/utilities.php. Suggestions?

2. 

   Cristian George Strat March 14, 2009, 1:23 a.m.

   I think your www/views/submit_form.php is the right place since task_get_submit_options() is UI code.

trunk/common/task.php (Diff revision 2)

Maintain coding style within files. {

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 5:38 a.m.

   fixed

trunk/www/controllers/json.php (Diff revision 2)

You cannot redirect(home) in JSON controllers since all requests are coming from XmlHttpRequest objects and they all  expect JSON output.

flash() works but probably not as intended. This will store a flash message in the server session and will display it on the next page that the user navigates to.


Bad AJAX requests should end with die_http_error(...).

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 6:43 a.m.

   Fixed. redirect and flash were also used when action was invalid, I changed that to die_http_error too.

trunk/www/controllers/submit.php (Diff revision 2)

Bleah... this is so contorted! isset($rounds) == True if.f. request_is_post() and $errors in safe_job_submit(...) and !$error in task_id...

I think it's nicer to just build $view as the condition tree above executes.

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 5:41 a.m.

   Done

trunk/www/controllers/submit.php (Diff revision 2)

views/submit.php doesn't seem to display a submit warning (task in multiple rounds) even though we might display a pre-selected task and round due to validation errors.

Maybe refactoring some <form> code in macro_tasksubmit helps.

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 6:43 a.m.

   fixed.

trunk/www/macros/macro_tasksubmit.php (Diff revision 2)

No inline styles.  :)

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 5:45 a.m.

   Forgot about these. Fixed

trunk/www/static/js/submit.js (Diff revision 2)

Does it work in IE?

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 5:46 a.m.

   I copied this code from wikiedit.js, so I assumed it will work.

trunk/www/static/js/submit.js (Diff revision 2)

OMG! Tabs? :)

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 5:46 a.m.

   Don't know how these got here. Fixed

trunk/www/static/js/submit.js (Diff revision 2)

typo

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 5:46 a.m.

   Fixed

trunk/www/views/submit.php (Diff revision 2)

We do (almost) the same in the submit macro. Is it possible to refactor this bit?

1. 

   Bogdan-Cristian Tătăroiu March 10, 2009, 6:45 a.m.

   I tried to unite them in views/submit_form.php. I'm not sure if it's the cleanest solution... It works :)

2. 

   Cristian George Strat March 14, 2009, 1:20 a.m.

   It's perfect!

This is good work!

I just wrote two comment replies. Other than those, this is ready for submission.