There are some inconsistent tabs in the change. Check that you don't mix tabs and spaces.

/trunk/common/db/smf.php (Diff revision 4)

How come this is id_group and somewhere else it's ID_GROUP?

1. 

   Savin Tiberiu Sept. 12, 2009, 4:15 p.m.

   ID_GROUP is the database column (smf is not very consistent), however the coding style says that variables should be lowercase. So in get_member_by_name I changed the names so that they match the IA coding style.

/trunk/common/db/smf.php (Diff revision 4)

If it exists, add the old group to additional_groups

/trunk/common/db/smf.php (Diff revision 4)

Should this be null, instead? They are different. Also, does smf still check for additional_groups if ID_GROUP is null?

1. 

   Savin Tiberiu Sept. 12, 2009, 4:19 p.m.

   I don't think it matter since the column is smallint in the database with default value 0 (cannot be null). And yes it checks.

/trunk/common/db/smf.php (Diff revision 4)

evil whitespace

/trunk/common/db/smf.php (Diff revision 5)

Maybe it's easier to do just two things:

* keep line 98 ('ID_GROUP' => ('admin' == $ia_user['security_level'] ? 1 : null),)
and
* always strip 1 from additionalGroups.

instead of doing all those checks.

1. 

   Bogdan-Cristian Tătăroiu Sept. 16, 2009, 11:13 p.m.

   What do you mean by that? That would still remove moderator privileges for non-admin people.
   

2. 

   Savin Tiberiu Sept. 16, 2009, 11:17 p.m.

   This wouldn't work because moderators have ID_GROUP = '2'. Doing that makes ID_GROUP 1 for admins and 0 for the others (db_update updates also null values). Also this function should also consider the case when an admin is demoted. That's why all those checks are made :).

/trunk/common/db/smf.php (Diff revision 5)

Indent

/trunk/common/db/smf.php (Diff revision 5)

Is "reglected" a typo?

1. 

   Savin Tiberiu Sept. 16, 2009, 11:18 p.m.

   It's a word i thought existed but aparently it doesn't :-"

/trunk/common/db/smf.php (Diff revision 5)

indent

/trunk/common/db/smf.php (Diff revision 5)

indent

/trunk/common/db/smf.php (Diff revision 5)

whitespace

/trunk/common/db/smf.php (Diff revision 5)

db_escape($username)