Fix diff between revisions sometimes erroring

Review Request #98 - Created Nov. 21, 2009 and submitted

Information
Bogdan-Cristian Tătăroiu
infoarena
Reviewers
hackers
The problem was caused by fread not reading the full data from pipes. It apparently reads things in chunks as their are outputed to the pipe and since we close the pipe after a single read, iconv error and says "broken pipe". Replaced fread with stream_get_contents as is exemplified in the php manual and everything works ok.

This has been on live for a day already :-"

Bogdan-Cristian Tătăroiu
Bogdan-Cristian Tătăroiu
Review request changed

Description:

   

The problem was caused by fread not reading the full data from pipes. It apparently reads things in chunks as their are outputed to the pipe and since we close the pipe after a single read, iconv error and says "broken pipe". Replaced fread with stream_get_contents as is exemplified in the php manual and everything works ok.

  +
  +

This has been on live for a day already :-"

Savin  Tiberiu
lcs.cpp should be checked because I/O operations seem a bit slow.
Loading...