Like, +1 and Tweet integration
Review Request #189 - Created Feb. 3, 2012 and submitted
| Information | |
|---|---|
| Adrian Budau | |
| infoarena | |
| Reviewers | |
| hackers | |
Added boxes for like +1 and tweet. The only things left to do are: 1) Use a different image than static/images/icon-user-64.gif because google+ requires at least 120px wide images 2) Make a twitter account for infoarena.ro and replace the constant IA_TWITTER_ACCOUNT with that
Bogdan-Cristian Tătăroiu
Review request changed
Trivial comments except for the ones about properly escaping urls.
-
trunk/www/controllers/blog.php (Diff revision 2) -
Don't think we need a meta_type, I can see adding stuff in meta_info that are not necessarily related to each other.
-
trunk/www/format/format.php (Diff revision 2) -
Indent this so that $ is to the right of the (
-
trunk/www/format/format.php (Diff revision 2) -
No == true
-
trunk/www/format/format.php (Diff revision 2) -
$url = url_absolute(...)
-
trunk/www/format/format.php (Diff revision 2) -
.= '' ? :P
-
trunk/www/format/format.php (Diff revision 2) -
html_escape(urlencode($url))
-
trunk/www/format/format.php (Diff revision 2) -
html_escape($url)
-
trunk/www/format/format.php (Diff revision 2) -
html_escape(urlencode($url))
-
trunk/www/static/css/screen.css (Diff revision 2) -
Fix your indents
-
trunk/www/format/format.php (Diff revision 3) -
What's the difference to urlencode?