Bigger details about blog post author
Review Request #192 - Created Feb. 3, 2012 and submitted
Information | |
---|---|
Cezar Mocan | |
infoarena | |
Reviewers | |
hackers | |
Moved the blog post author up, under the title, made the font bigger and added the 75x75 avatar. What needs to be done:
Code looks good, nice work. Can you attach a screenshot please?
-
trunk/www/static/css/screen.css (Diff revision 1) -
Perhaps a more descriptive name? :D
-
trunk/www/views/blog_index.php (Diff revision 1) -
Weird indent
-
trunk/www/views/blog_index.php (Diff revision 1) -
I believe 'creation_timestamp' is the raw data that comes from the db. You should probably call format_date($subpage['creation_timestamp'], 'd M Y') so we have it be the same format as before.
Review request changed
Change Summary:
Corrected the code. Added the social buttons inside the blog post header.
Description: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+43 -9) |
Review request changed
Change Summary:
Removed the extra newline in recaptchalib which broke attachments.
Diff: |
Revision 3 (+43 -10) |
---|
-
trunk/common/external_libs/recaptchalib.php (Diff revision 3) -
A coding style that Facebook used was to never use the trailing ?>, exactly because of this behaviour. They have open-sourced their php linter at github.com/facebook/arcanist and github.com/facebook/phutil. We'll be starting to use that, so might as well start removing these already when you get the change. Once everything is ported to XHP, there will be no reason to ever leave use ?> to enter templateing mode.