Changes visibility for solved tasks
Review Request #195 - Created Feb. 21, 2012 and submitted
| Information | |
|---|---|
| Andrei Grigorean | |
| infoarena | |
| Reviewers | |
| hackers | |
Changes visibility for all the tasks a user has solved in an archive.
Issues
- 1
- 3
- 0
- 4
| Description | From | Last Updated |
|---|---|---|
| I don't always test my code, but when I do, I do it in production... |
Bogdan-Cristian Tătăroiu
|
Savin Tiberiu
Review request changed
Status: Re-opened
Summary: |
|
|||
|---|---|---|---|---|
Description: |
|
|||
Groups: |
|
|||
Diff: |
Revision 1 (+21 -15) |
-
/trunk/common/security.php (Diff revision 1) -
brackets
-
/trunk/common/security.php (Diff revision 1) -
use constant for 100 define MAX_SCORE 100 score == MAX_SCORE. Also use: if (..) { ... }
-
/trunk/common/security.php (Diff revision 1) -
I think this may have serious consequences on site performance. You will be doing 25 extra queries for a monitor page view, which is pretty bad. There needs to be some sort of caching for this stuff. Also, wouldn't you say that if a user has solved task X in the archive, he should be able to see jobs for task X that were submitted during a contest?
Review request changed
-
/trunk/common/db/score.php (Diff revision 2) -
I don't always test my code, but when I do, I do it in production...
Looks good to me at 01:26, hope it actually works :D