Fast fix for task filtering
Review Request #204 - Created April 10, 2012 and submitted
Information | |
---|---|
Adrian Budau | |
infoarena | |
Reviewers | |
hackers | |
Task filtering suffered some changes: 1) No more duplicates 2) now shows the source of the task not the round(arhiva or arhiva-educationala) 3) removed hard-coded select based on arhiva and arhiva-educationala rounds 4) now sorts task lexicographic because we no longer use rounds to determine order_id 5) now shows max score in an archive type round on each task instead of the score in 'arhiva' round
Ship It!
Review request changed
Change Summary:
Corrected some problems and also made some changes to how task filtering works now. Description updated
Description: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+12 -13) |
Looks good :)
-
trunk/common/db/task.php (Diff revision 2) -
I believe you don't need DISTINCT when you GROUP BY
Review request changed
Change Summary:
Some fixes for when the first_entry was >= total_entries and a problem with the tasks that weren't solved(they didn't appear in the list).
Diff: |
Revision 4 (+11 -4) |
---|
Hopefully everything is ok now :D
-
trunk/common/db/task.php (Diff revision 4) -
haha I find this rather funny :)