Multiple file uploading - feature
Review Request #206 - Created April 23, 2012 and submitted
Information | |
---|---|
Adrian Budau | |
infoarena | |
Reviewers | |
hackers | |
Gives multiple file upload capability for google chrome, mozilla firefox and Safari with only one "input" tag. Zip can be considered deprecated. Still relies on apache to work(hiphop-php doesn't know zip archives). Also fixed some lint warnings.
Good job. Out of curiosity, does this work on any version of IE? 7/8/9 Also, http://goo.gl/5B3hX, that controller was 300 lines long.
-
trunk/www/controllers/attachment.php (Diff revision 2) -
Check that it's an array as well.
-
trunk/www/controllers/attachment.php (Diff revision 2) -
Zip is still useful for uploading big text files that are compressed to something small. Slow internet users will benefit from it.
-
trunk/www/controllers/attachment.php (Diff revision 2) -
You should probably make this an array and do an implode("\n", ) at the end, in case there's more than one file with errors.
-
trunk/www/controllers/attachment.php (Diff revision 2) -
Same as before
-
trunk/www/controllers/attachment.php (Diff revision 2) -
Remove these
-
trunk/www/controllers/attachment.php (Diff revision 2) -
Do you not get the MIME type of the attachment in $_FILES? That should be more reliable than the extension.
-
trunk/www/controllers/attachment.php (Diff revision 2) -
Remove this as well
Review request changed
Change Summary:
Hopefully fixed last review problems. This patch works ONLY for google chrome, moziila firefox and Safari. Single file upload still works in the other browsers(IE..., Opera)
Diff: |
Revision 3 (+117 -98) |
---|
Slightly late review, good work. :D
-
trunk/www/controllers/attachment.php (Diff revision 3) -
este invalid
-
trunk/www/controllers/attachment.php (Diff revision 3) -
Use COUNT_RECURSIVE instead of 1, I had to look up what 1 does, whereas it would be much clearer with COUNT_RECURSIVE. I counted 6 occurrences which I think you should change.
-
trunk/www/views/utilities.php (Diff revision 3) -
if (...) { ... }