Further cleanups to eval code in preparation for interactive tasks.
Review Request #213 - Created June 23, 2012 and submitted
Information | |
---|---|
Bogdan-Cristian Tătăroiu | |
infoarena | |
Reviewers | |
hackers | |
- Fixed error handling for various methods such as chmod, which would have raised PHP warnings and killed the eval. - Replace previous hack with exceptions whenever judging a job needed to be interrupted due to an error. Replaced all log_error and log_assert with calls to eval_assert, which raises a EvalSystemError on failed assertion. - Got rid of task parameters in the grader code. Parameters are now merged into the $task object. - Linting fixes. - Fix site crash when mbstring extension not present.
Great job. I hope you tested all possible exception cases.
-
trunk/eval/BaseGrader.php (Diff revision 1) -
Are you sure there are no more problems with preg_match? In php 5.3 ubuntu 11.10 I know I had some problems with it(not here but still with preg_match).
-
trunk/eval/Exceptions.php (Diff revision 1) -
Make it abstract?
-
trunk/eval/Exceptions.php (Diff revision 1) -
Same here