Implement detailed feedback
Review Request #46 - Created Dec. 12, 2008 and submitted
| Information | |
|---|---|
| Bogdan-Cristian Tătăroiu | |
| infoarena | |
| Reviewers | |
| hackers | |
- Moved (and renamed) task parameters "tests", "testgroups", "okfiles" and "evaluator" to ia_task (they will be common to every task type anyway). Only memlimit and timelimit remain in ia_parameter_value for tasks. - Added 'public_tests' column to ia_task in which you can specify tests for detailed feedback in the same format as a group in 'test_groups' - Modified job_detail to show results on public tests :P - Move score and size hiding in monitor from view to controller
Looks good to me. Since this changeset contains some major changes I want Cristi to also take a look at it before putting it on live.
This is good stuff! I'm especially happy we're getting rid of more evil task params. :)
-
/trunk/common/task.php (Diff revision 2) -
Maybe test_count?
-
/trunk/common/task.php (Diff revision 2) -
NULL?
-
/trunk/common/task.php (Diff revision 2) -
Good job splitting the original function!
-
/trunk/eval/classic_grader.php (Diff revision 2) -
Remember to change this also if you will allow $task['evaluator'] to be NULL.
-
/trunk/eval/classic_grader.php (Diff revision 2) -
Same reminder as above.
-
/trunk/www/controllers/monitor.php (Diff revision 2) -
The monitor should warn the user when detailed feedback is available.
-
/trunk/www/macros/macro_taskparam.php (Diff revision 2) -
Thanks for cleaning up!
-
/trunk/www/views/job_detail.php (Diff revision 2) -
Use a boolean or NULL convention instead.
Review request changed
Change Summary:
- Added "job-view-partial-feedback" permission. Users should only be able to see their own feedback, not that of others - Added "job-view-score" permission check to job_view_source controller (this is already on live, forgot to put it in svn) - Fixed things mentioned in review
Diff: |
Revision 3 (+324 -202) |
|---|