Shouldn't $timeout be reseted when a connection is established again?
If we have 10 failed attempts, but the DB link is acquired again, on the next failed attempt (say, one month later), timeout will still be maxed out at 60.

trunk/common/db/db_mysql.php (Diff revision 2)

Why don't we use IA_DB_KEEP_ALIVE instead of adding another parameter to the db_connect function. I don't think we'll ever need to use db_connect(false). This could also lead to wrong output if IA_DB_KEEP_ALIVE is true and $try_keepalive is false. In case the connection fails we would log_warn("Retrying...") and we wouldn't be doing that.

trunk/common/db/db_mysql.php (Diff revision 2)

split this in something like:

log_warn($log_message);
if ($try_keepalive) {
    ...
    log_warn($log_message);
}

Either this either remove the $try_keepalive parameter.

1. 

   Bogdan-Cristian Tătăroiu Nov. 3, 2009, 6:05 a.m.

   try_keepalive is not the best name for that parameter to explain what it does, but I lack a better one. :) 
   
   I'll copy a part of what I said in my previous comment:
   
   db_keepalive is called as a retry method from db_connect only the first time a database connection is attempted (that's what the try_keepalive argument is used for). The actual retrying is done in the db_keepalive method.
   
   You can't have db_connect call db_keepalive which calls db_connect which calls db_keepalive etc. because that would cause a big recursive loop if the server is down for example.
   
   Maybe you have a better solution to this than adding that extra parameter :) I couldn't think of one.