Filter tasks by tag
Review Request #127 - Created Dec. 22, 2009 and submitted
| Information | |
|---|---|
| Savin Tiberiu | |
| infoarena | |
| Reviewers | |
| hackers | |
Tasks can be filtered by tags. Since we need to pass an array through a GET request I had to modify url_from_args to accept this.
Where do you make the tasks from arhiva educationala be the first ones in the list? :)
-
/trunk/common/db/task.php (Diff revision 1) -
db_quote should already do the 's if they are necessary. $tag_ids are also integers so no 's are necessary.
-
/trunk/common/db/task.php (Diff revision 1) -
Why the CONVERT? You should add a separator to GROUP_CONCAT if we really need it :)
-
/trunk/common/db/task.php (Diff revision 1) -
Don't fetch author, authors will be tags.
-
/trunk/common/db/task.php (Diff revision 1) -
You should look at tag_build_where so you don't have to do this is php.
-
/trunk/www/controllers/task.php (Diff revision 1) -
Check that each element of $tags is_tag_id.
-
/trunk/www/controllers/task.php (Diff revision 1) -
ă
-
/trunk/www/macros/macro_algorithmtags.php (Diff revision 1) -
html_escape :) Maybe look into using format_link since it's more standard for us.
-
/trunk/www/macros/macro_algorithmtags.php (Diff revision 1) -
It's
-
/trunk/www/url.php (Diff revision 1) -
no log_print_r in production code:)
-
/trunk/www/url.php (Diff revision 1) -
evil space
-
/trunk/www/url.php (Diff revision 1) -
Are you sure this works for multiple values of $v? It seems it will overwrite the same key.
-
/trunk/www/url.php (Diff revision 1) -
no log_print_r in production code:)
-
/trunk/www/url.php (Diff revision 1) -
bad indentation
-
/trunk/www/views/task_filter_results.php (Diff revision 1) -
Remove the author column for now until I put up my review with showing author tags.
-
/trunk/common/db/task.php (Diff revision 2) -
identity_is_anonymous() is website related, and doesn't really belong in the model related files. I suggest adding a $user_id parameter like for round_get_tasks.
-
/trunk/common/db/task.php (Diff revision 2) -
bad indent
-
/trunk/www/macros/macro_algorithmtags.php (Diff revision 2) -
here also.   is not valid html.
-
/trunk/www/url.php (Diff revision 2) -
evil empty line?
-
/trunk/www/url.php (Diff revision 2) -
I don't really like the url, infoarena.ro/cauta-probleme seems nicer.
-
/trunk/www/views/task_filter_results.php (Diff revision 2) -
You can add authors like in my review now.
-
/trunk/common/db/task.php (Diff revision 3) -
evil space
-
/trunk/common/db/task.php (Diff revision 3) -
evil space
-
/trunk/www/controllers/task.php (Diff revision 3) -
evil space
-
/trunk/www/views/task_filter_results.php (Diff revision 3) -
evil space