Admin edit button
Review Request #129 - Created Dec. 26, 2009 and submitted
Information | |
---|---|
Teodor Pripoae | |
infoarena | |
Reviewers | |
hackers | |
Solved ticket #308: http://hackers.devnet.ro/ticket/308
-
/trunk/common/textblock.php (Diff revision 1) -
Add a comment with what this function does and returns and rename it to textblock_is_task. It should receive a textblock if you place it in this file, not a security descriptor and I think it's better that it return the task's id, so it doesn't make the query for the task unless you really have too. You should also replace the regexp in common/security.php with this function (it appears two times there I think).
-
/trunk/common/textblock.php (Diff revision 1) -
This is left over from the copied code from common/security. This should have been return false.
-
/trunk/www/views/textblock_header.php (Diff revision 1) -
Add a link to edit the task's tags while you are at it.
Review request changed
-
trunk/common/security.php (Diff revision 2) -
Here you do need the require_once
-
trunk/common/security.php (Diff revision 2) -
Change this to use textblock_is_task also.
-
trunk/common/textblock.php (Diff revision 2) -
A more friendly comment :P If textblock security descriptor is a task, returns the task's id, otherwise return false.
-
trunk/common/textblock.php (Diff revision 2) -
Either call it textblock_security_is_task or pass a textblock, not a security descriptor.
-
trunk/common/textblock.php (Diff revision 2) -
No need for require_once here.
-
trunk/common/security.php (Diff revision 3) -
Our coding style enforces maximum 80 characters per line, so put the enter back here :)
-
trunk/common/textblock.php (Diff revision 3) -
Remove this empty line.
-
trunk/www/views/textblock_header.php (Diff revision 3) -
textblock_security_is_task
-
trunk/www/views/textblock_header.php (Diff revision 3) -
We should call it "Editeaza enunt" for tasks.