Minor changes regarding table looks
Review Request #154 - Created April 24, 2010 and submitted
| Information | |
|---|---|
| Andrei Grigorean | |
| infoarena | |
| Reviewers | |
| hackers | |
Adds a table sorting feature. Preserves row parity for sorting and drag n drop.
Only small comments.
-
trunk/www/macros/macro_stars.php (Diff revision 1) -
We discourage inline styles. class="hidden" is better.
-
trunk/www/static/js/restoreparity.js (Diff revision 1) -
Why not just do table.getElementsByTagName("tr")? Do we acutally put header lines in <thead> ? -
trunk/www/static/js/sorttable.js (Diff revision 1) -
Do you mind removing trailing whitespace with vim? :)
-
trunk/www/static/js/tablednd.js (Diff revision 1) -
Will this work if I drag down really fast? :)
Only small comments.
-
trunk/www/static/js/restoreparity.js (Diff revision 1) -
Why not just do table.getElementsByTagName("tr")? Do we acutally put header lines in <thead> ?
-
trunk/www/macros/macro_stars.php (Diff revision 1) -
Done.
-
trunk/www/static/js/restoreparity.js (Diff revision 1) -
Yes, we do.
-
trunk/www/static/js/sorttable.js (Diff revision 1) -
Done
-
trunk/www/static/js/tablednd.js (Diff revision 1) -
Fixed.