Make infoarena compatible with HPHP.

Reviews
Diff

- Download Diff

Information
Submitter:	Bogdan-Cristian Tătăroiu
Repository:	infoarena
Branch:
Bugs:
Depends On:
Reviewers
Groups:	hackers
People:

Description

- Implemented APC caching support since eaccelerator is not compatible
  with HPHP and although we support memcached, we do not use it on live.
- Replaced instances of create_function_cached with php anonymous
  functions. This bumps the PHP version requirement to 5.3, but it
  allows the code to work with HPHP, since dynamic function generation
  is replaced with staticly analyzable functions. This also removes a
  horrible, terrible hack in Textile.php which was storing the current
  instance of the Textile class being processed as a static variable so
  that it could be accessed by anonymous functions.
- Replaced occurrences of assert with log_assert.
- When running under HPHP, IA_HPHP_ENV is defined and is used to bypass
  some incompatible code (redundant ini configuration checks).
- Fixed some includes that were dependent on the working directory being
  www/
- Included a sample HPHP configuration file and a Makefile with
  compilation commands.

Testing Done

Issues

2
1
1
All Issues: 4

Description	From	Last Updated
This causes a crash on the site if the IA_HPHP_ENV is not defined. change it to: if (defined('IA_HPHP_ENV')) maybe?	Adrian Budau	Jan. 8, 2012, 3:31 p.m.
why? what if you want to cache a function that's very cpu expensive that sometimes returns false?. Looks to me ...	Savin Tiberiu	Jan. 14, 2012, 8:39 p.m.
65 what? MB? KB?	Savin Tiberiu	Feb. 11, 2012, 3:36 a.m.
why?? does hphp not support more or what?	Savin Tiberiu	Feb. 11, 2012, 3:36 a.m.

Fix it!

trunk/www/identity.php (Diff revision 1)

Show all issues

This causes a crash on the site if the IA_HPHP_ENV is not defined. change it to:
if (defined('IA_HPHP_ENV')) maybe?

Adrian Budau Jan. 8, 2012, 9:12 p.m.

I also installed APC and it seems to be working.

Ship it!

Ship It!

Change Summary:

Fixed IA_HPHP_ENV error
Updated Makefile compilation command for a speed boost

Description:

		Implemented APC caching support since eaccelerator is not compatible with HPHP and although we support memcached, we do not use it on live.
		Replaced instances of create_function_cached with php anonymous functions. This bumps the PHP version requirement to 5.3, but it allows the code to work with HPHP, since dynamic function generation is replaced with staticly analyzable functions. This also removes a horrible, terrible hack in Textile.php which was storing the current instance of the Textile class being processed as a static variable so that it could be accessed by anonymous functions.
		Replaced occurrences of assert with log_assert.
		When running under HPHP, IA_HPHP_ENV is defined and is used to bypass some incompatible code (redundant ini configuration checks).
		Fixed some includes that were dependent on the working directory being www/
	+	Included a sample HPHP configuration file and a Makefile with compilation commands.

Diff:

Revision 2 (+325 -150)

Show changes

	trunk/Makefile
	trunk/common/cache.php
	trunk/common/common.php
	trunk/common/textblock.php
	trunk/common/db/attachment.php
	trunk/hphp/config.hdf.sample
	trunk/hphp/endpoint/index.php
	trunk/www/config.php
	23 more

Change Summary:

Fixed small bug that appeared at deployment with the rankings macro.

Diff:

Revision 3 (+326 -150)

Show changes

	trunk/Makefile
	trunk/common/cache.php
	trunk/common/common.php
	trunk/common/textblock.php
	trunk/common/db/attachment.php
	trunk/hphp/config.hdf.sample
	trunk/hphp/endpoint/index.php
	trunk/www/config.php
	23 more

Fix it!

trunk/common/cache.php (Diff revision 3)

Show all issues

why? what if you want to cache a function that's very cpu expensive that sometimes returns false?. Looks to me like this could generate a ton of errors.

Bogdan-Cristian Tătăroiu Jan. 14, 2012, 9:10 p.m.

I honestly have no idea, it's the same for memcache and eaccelerator functions, so I just copied it over.
It compares the object to the string 'false', not to the boolean false, so I don't know what it's trying to achieve.

Savin Tiberiu Jan. 14, 2012, 10:34 p.m.

oh now i see it's the string 'false'. Doesn't make any sense to me. Still I think it's better to just not cache and issue a warning, not log_assert. It would be really bad if you made a function get_username, cache it and then on live when someone with the username 'false' tries to navigate the website and the site would crash because of that.

trunk/hphp/config.hdf.sample (Diff revision 3)

Show all issues

65 what? MB? KB?

Bogdan-Cristian Tătăroiu Jan. 14, 2012, 9:10 p.m.

That's MB, I'll add a comment next commit. It's limited to the maximum allowed size of an attachment + 1MB. Not sure if we need the +1, but I guess it won't hurt.

trunk/www/config.php (Diff revision 3)

Show all issues

why?? does hphp not support more or what?

Bogdan-Cristian Tătăroiu Jan. 14, 2012, 9:10 p.m.

It was 64MB on live when I was writing this patch, so I updated it in here as well. At least it's nice and round now :)

Ship it!

Looks good. Good job :)

Ship it!

You could mark it as submitted. It shouldn't stay in active reviewboard requests.

You have a pending review.

Review Board 2.5.13.1

Screenshots

Files

Issues

Change Summary:

Description:

Diff:

Change Summary:

Diff:

Status: Closed (submitted)